Skip to content

Bump rustls to 0.23.45 - #2847

Merged
j178 merged 1 commit into
masterfrom
rustls
Oct 9, 2026
Merged

j178 merged 1 commit into
masterfrom
rustls

Conversation

@j178

@j178 j178 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 10:54
@j178 j178 added the internal Internal changes label Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@j178
j178 deployed to release October 9, 2026 10:54 — with GitHub Actions Active
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T10:56:00.701460Z 6f103b1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.33%. Comparing base (8b894a7) to head (6f103b1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2847   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         143      143           
  Lines       30847    30847           
=======================================
  Hits        29100    29100           
  Misses       1747     1747           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@j178
j178 deployed to release October 9, 2026 11:04 — with GitHub Actions Active
@prek-ci-bot

prek-ci-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

.text size change: +0.00% (12.9 MiB → 12.9 MiB)

Expand for cargo-bloat output

Head Branch Results

File  .text     Size             Crate Name
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_encrypt_avx512
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_decrypt_avx512
0.0%   0.7%  91.8KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  50.3KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.4%  47.5KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  45.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  39.5KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  35.4KiB              prek prek::run::{closure#0}
0.0%   0.2%  29.5KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.8KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.2KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::cli::hook_impl::hook_impl::{closure#0}
0.0%   0.2%  26.5KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
4.1%  87.3%  11.3MiB                   And 20832 smaller methods. Use -n N to show more.
4.7% 100.0%  12.9MiB                   .text section size, the file size is 277.3MiB

Base Branch Results

File  .text     Size             Crate Name
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_encrypt_avx512
0.1%   2.5% 332.0KiB        aws_lc_sys aws_lc_0_45_0_aes_gcm_decrypt_avx512
0.0%   0.7%  91.8KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  50.3KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.4%  47.5KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  45.0KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<&mut <serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  39.5KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  35.4KiB              prek prek::run::{closure#0}
0.0%   0.2%  29.5KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.8KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_45_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.2KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.1KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::cli::hook_impl::hook_impl::{closure#0}
0.0%   0.2%  26.5KiB              prek <prek::languages::ruby::installer::RubyInstaller>::install::{closure#0}
4.1%  87.3%  11.3MiB                   And 20799 smaller methods. Use -n N to show more.
4.7% 100.0%  12.9MiB                   .text section size, the file size is 277.1MiB

@prek-ci-bot

prek-ci-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 4 regressions, 3 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1022-azure
  • CPU: 4 cores
  • prek version: prek 0.5.5+8 (67329b2 2026-10-09)
  • Rust version: rustc 1.99.0 (b940084d7 2026-09-28)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 1.8 ± 0.2 1.6 2.7 1.05 ± 0.10
prek-head --version 1.7 ± 0.1 1.6 1.9 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 6.7 ± 0.4 6.3 9.6 1.00
prek-head list 7.4 ± 2.5 6.3 20.1 1.10 ± 0.38

⚠️ Warning: Performance regression for prek list: 10.0100% slower

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 4.4 ± 3.2 2.0 12.1 1.87 ± 1.65
prek-head sample-config 2.4 ± 1.2 2.0 8.7 1.00

✅ Performance improvement for prek sample-config: 46.4900% faster

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 14.3 ± 0.7 13.2 15.4 1.03 ± 0.06
prek-head run --all-files 13.9 ± 0.6 13.0 14.9 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 14.8 ± 2.3 13.4 24.0 1.09 ± 0.19
prek-head run --all-files 13.6 ± 0.9 12.5 16.4 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 14.3 ± 2.5 12.5 30.8 1.05 ± 0.19
prek-head run --all-files 13.7 ± 0.8 12.3 15.9 1.00
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 7.3 ± 0.6 6.3 9.7 1.07 ± 0.13
prek-head run trailing-whitespace --all-files 6.8 ± 0.6 6.0 7.8 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 6.0 ± 0.4 5.5 7.1 1.00
prek-head run end-of-file-fixer --all-files 7.6 ± 3.1 5.7 17.4 1.27 ± 0.52

⚠️ Warning: Performance regression for prek run end-of-file-fixer --all-files: 26.5600% slower

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 5.4 ± 0.4 5.0 6.3 1.03 ± 0.08
prek-head run check-json --all-files 5.2 ± 0.2 5.0 5.7 1.00

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 5.6 ± 0.4 5.2 7.2 1.00
prek-head run check-yaml --all-files 5.7 ± 0.7 5.2 8.9 1.03 ± 0.15

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 5.4 ± 0.4 4.9 6.4 1.00
prek-head run check-toml --all-files 5.5 ± 1.9 4.8 15.5 1.03 ± 0.36

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 5.7 ± 1.0 5.0 9.1 1.00
prek-head run check-xml --all-files 6.6 ± 3.4 4.9 19.0 1.16 ± 0.63

⚠️ Warning: Performance regression for prek run check-xml --all-files: 15.6000% slower

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 5.3 ± 0.3 5.1 6.6 1.00
prek-head run detect-private-key --all-files 5.5 ± 0.4 5.1 6.5 1.04 ± 0.09

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 5.8 ± 0.2 5.5 6.4 1.00
prek-head run fix-byte-order-marker --all-files 7.1 ± 4.3 5.4 28.7 1.22 ± 0.75

⚠️ Warning: Performance regression for prek run fix-byte-order-marker --all-files: 22.3100% slower

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 3.9 ± 0.1 3.8 4.0 1.00
prek-head install-hooks 3.9 ± 0.1 3.9 4.0 1.01 ± 0.04

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.8 ± 2.1 3.7 8.7 1.31 ± 0.59
prek-head install-hooks 3.7 ± 0.1 3.5 3.8 1.00

✅ Performance improvement for prek install-hooks (warm - with cache): 23.7000% faster

File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 8.2 ± 0.4 7.7 9.2 1.02 ± 0.06
prek-head run 8.1 ± 0.3 7.5 8.8 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 4.0 ± 0.1 3.8 4.3 1.00
prek-head run --files '*.json' 4.4 ± 0.6 4.0 6.9 1.09 ± 0.16
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 5.4 ± 0.1 5.1 5.8 1.00
prek-head run --dry-run --all-files 5.6 ± 0.6 5.3 8.1 1.04 ± 0.12
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 6.9 ± 0.6 6.1 8.8 1.00
prek-head run check-hooks-apply --all-files 7.2 ± 0.5 6.3 8.0 1.06 ± 0.12

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 7.7 ± 2.4 6.4 16.1 1.19 ± 0.38
prek-head run check-useless-excludes --all-files 6.4 ± 0.3 6.1 7.2 1.00

✅ Performance improvement for prek run check-useless-excludes --all-files: 16.2700% faster

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 5.4 ± 0.1 5.2 5.6 1.00
prek-head run identity --all-files 5.6 ± 0.2 5.5 6.2 1.03 ± 0.04

@j178
j178 merged commit d06ad64 into master Oct 9, 2026
39 checks passed
@j178
j178 deleted the rustls branch October 9, 2026 11:06

This branch was successfully deployed

1 active deployment
release — 6f103b15 Deployed Oct 9, 2026 by j178 via build-docker / Build Alpine Docker image #6775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants