Skip to content

Conversation

@kallyaleksiev
Copy link
Contributor

Context

This PR addresses #183 by bumping isolated-vm to 6.0.0

Tests via pnpm test pass

@netlify
Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for webcrack ready!

Name Link
🔨 Latest commit a4f650c
🔍 Latest deploy log https://app.netlify.com/projects/webcrack/deploys/68a0bf8cf00d320008d483b3
😎 Deploy Preview https://deploy-preview-184--webcrack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@j4k0xb
Copy link
Owner

j4k0xb commented Jun 27, 2025

Thanks for the PR

This breaks compatibility with node 18.x and 20.x unfortunately (majority of users), I can merge after laverdet/isolated-vm#532 and/or laverdet/isolated-vm#534 is resolved

@ItsHarper
Copy link
Contributor

ItsHarper commented Aug 13, 2025

I'm preparing a soft-fork at https://github.com/ItsHarper/webcrack / https://itsharper-webcrack.netlify.app/, which I'm only planning on keeping active until this PR (or perhaps the more complete ItsHarper@32d6157) gets commited to the upstream version. I'm also planning to update to the babel 8 beta (see my fork's readme).

@j4k0xb Do you mind if I call it @itsharper/webcrack? I'm linking to your version both in the GitHub README and on the playground site.

@j4k0xb
Copy link
Owner

j4k0xb commented Aug 15, 2025

@ItsHarper sure you can do it if you want
for this repo there seems to be no other choice than to update to isolated-vm v6 and release a new major version (breaking change)

@ItsHarper
Copy link
Contributor

ItsHarper commented Aug 16, 2025

Node.js is practically begging people to upgrade to version 22 anyway: https://nodejs.org/en/blog/announcements/node-18-eol-support. I think there's value in helping nudge people in that direction.

@j4k0xb j4k0xb merged commit bc8093f into j4k0xb:master Aug 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants