Skip to content

feat(skills-generator): add Feature Toggles skill#980

Open
wipheg wants to merge 1 commit into
jabrena:mainfrom
wipheg:feat/965-feature-toggles-skill
Open

feat(skills-generator): add Feature Toggles skill#980
wipheg wants to merge 1 commit into
jabrena:mainfrom
wipheg:feat/965-feature-toggles-skill

Conversation

@wipheg

@wipheg wipheg commented Jul 7, 2026

Copy link
Copy Markdown

Summary

Closes #965

  • Add 057-design-feature-toggles skill XML sources for Java enterprise feature toggle guidance
  • Register the new skill in skills.xml
  • Add Gherkin coverage and acceptance prompt inventory entry
  • Normalize generated-content line splitting in SkillReferenceGeneratorTest for CRLF-safe validation on Windows

Validation

  • Ran .\mvnw.cmd clean verify -pl skills-generator
  • Verified generated local output:
    • .agents/skills/057-design-feature-toggles/SKILL.md
    • .agents/skills/057-design-feature-toggles/references/057-design-feature-toggles.md

Notes

The public skills/ release output was intentionally left unchanged. This PR updates the XML sources and verifies local generated output under .agents/skills/; release output should be refreshed only when preparing a release.

@wipheg wipheg requested a review from jabrena as a code owner July 7, 2026 13:51

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the reference, should have examples not another workflow. the Skill has the workflow but the reference could have examples.

@jabrena

jabrena commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Hi @wipheg , I need that commits use your personal email:

Author: wipheg <63744049+wipheg@users.noreply.github.com>
Date:   Tue Jul 7 22:49:01 2026 +0900

    feat(skills-generator): add feature toggles skill
    
    Add the 057-design-feature-toggles skill XML sources, inventory registration, Gherkin coverage, and acceptance prompt entry.
    
    Normalize generated-content line splitting in the skill reference generator test so CRLF output validates consistently on Windows.
    
    Co-authored-by: Codex <codex@openai.com>

As in your feature branch, you only did a commit, you could uncommit the last commit and update commit message including that information.

Note: I will upgrade the contributing document to avoid this issues in the future.

Juan Antonio

Add the 057-design-feature-toggles skill XML sources, inventory registration, Gherkin coverage, and acceptance prompt entry.

Normalize generated-content line splitting in the skill reference generator test so CRLF output validates consistently on Windows.

Co-authored-by: Codex <codex@openai.com>
@wipheg wipheg force-pushed the feat/965-feature-toggles-skill branch from e3fa047 to db7fb6f Compare July 9, 2026 10:17
@wipheg

wipheg commented Jul 9, 2026

Copy link
Copy Markdown
Author

Thanks for the review, @jabrena.
I updated the feature toggles reference to focus on concrete examples instead of another workflow, and amended the commit to use my personal email.

@jabrena

jabrena commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Verified:

Author: wipheg <won159951@gmail.com>
Date:   Tue Jul 7 22:49:01 2026 +0900

    feat(skills-generator): add feature toggles skill
    
    Add the 057-design-feature-toggles skill XML sources, inventory registration, Gherkin coverage, and acceptance prompt entry.
    
    Normalize generated-content line splitting in the skill reference generator test so CRLF output validates consistently on Windows.
    
    Co-authored-by: Codex <codex@openai.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add skill about Feature Toggles

2 participants