Seperated Discord implementation and added MS Teams#1
Seperated Discord implementation and added MS Teams#1wwa-jvteeffelen wants to merge 10 commits intojack-mil:masterfrom
Conversation
|
Hi there, and thank you for your PR! I didn't think anyone else was actually using this, haha. It might be a little while before I can properly review and merge, and I can't test it personally because I don't use MS Teams. But the commits will be available here in the mean-time for anyone else that is looking for additional services! |
remove deprecated version: in docker-compose
|
ah, have you been noticing that too! sometimes It returns the 104.18.0.0 broadcast address!? |
|
Yes it was the exact same here for some reason. Good thing you already had those other 2 providers set there. Only needed to parse it slightly differently to make that work. It would maybe be neater to use an enum provider and use different parsing options per provider, but this was just a quick fix to get it working again. |
Cloudflare stopped working for some reason, and I don't trust them anymore anyway. Open to other privacy respecting and/or simple recs. Related to #1
|
I quickly added a fix for the Cloudflare issue like you did. When I have more time, I do want to revisit including the teams stuff you worked on, and also add the dependencies to the script and pin versions for use with uv run etc. |
I am sure the embed card for Teams could use lots of fancy features but I can't test it. Original implementation from contributor in #1 Co-authored-by: J.J. van Teeffelen <j.vteeffelen@wwa.nl>
|
Can you test out the implementation of the Teams notification on the Your separate interfaces and classes approach is probably exactly how it should be done if this was a complex real application, but for this I kinda just want to keep a simple single-file python script for convenience. So I just added a new function. If everything looks good from your side, I'll merge that commit into master then close this PR out. Feel free to add any additional info/styling to the teams payload if you want after that. |
add configuration instruction per service in readme
|
Verified it to work. I've also updated the readme with extra instructions |
I am sure the embed card for Teams could use lots of fancy features but I can't test it. Original implementation from contributor in #1 Co-authored-by: J.J. van Teeffelen <j.vteeffelen@wwa.nl>
|
So the webhook payload version number decreased? OK that sounds weird but I added it in bd0dcf5. Thanks for the docs part too. Going to close this PR now, but feel free to open more if something is still not right. I will be monitoring and mirroring back to this repo Github for the time being, but if you have Codeberg, I am in the process of migrating most of my things over there. Up to you. https://codeberg.org/jack-mil/ip-notify/ |
2 participants
Hey, thank you for this cool little application!
I was looking for something similar, but wanted to use a different service, so I put the Discord functionality in a different file and added an option for MS Teams for it.
Figured I could open a PR so others might also find use for it.