refactor(sitemaps): promote global seed to top-level sitemaps/#1826
Merged
Conversation
Per @WAWQAQ discoverability question — `skills/opencli-sitemap-author/references/site-memory/<site>/sitemap/` is buried 5 levels deep. Move to top-level `sitemaps/<site>/` to make Site Maps Hub a first-class repo citizen, parallel to `clis/`, `skills/`, `docs/`. Why now: only 2 seeds (twitter, hackernews) so migration cost is minimal. Doing this after dozens of seeds land would be far worse. Changes: - `git mv` twitter + hackernews seeds to `sitemaps/<site>/` - Flatten the inner `sitemap/` subdirectory (now redundant — top-level `sitemaps/` already disambiguates) - `sitemapPathsForSite` in src/cli.ts: globalBase changed to `<packageRoot>/sitemaps/<site>/` - src/cli.test.ts: test path updated - opencli-sitemap-author SKILL.md: Storage Model section - opencli-browser-sitemap SKILL.md: Lookup Order section Local overlay path (`~/.opencli/sites/<site>/sitemap/`) is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @WAWQAQ's discoverability question — the global seed was buried 5 levels deep at
skills/opencli-sitemap-author/references/site-memory/<site>/sitemap/. Move to top-levelsitemaps/<site>/to make Site Maps Hub a first-class repo citizen, parallel toclis/,skills/,docs/.Why now
Only 2 seeds (twitter, hackernews) exist today. Migration cost is minimal. Doing this after dozens of Phase 2 seeds land would be far worse.
Changes
git mvtwitter + hackernews seeds tositemaps/<site>/sitemap/subdirectory (now redundant — top-levelsitemaps/already disambiguates)sitemapPathsForSiteinsrc/cli.ts:globalBasechanged to<packageRoot>/sitemaps/<site>/src/cli.test.ts: test path updated, 3 unit tests passopencli-sitemap-author/SKILL.md: Storage Model sectionopencli-browser-sitemap/SKILL.md: Lookup Order sectionLocal overlay path (
~/.opencli/sites/<site>/sitemap/) is unchanged.After this lands
@opencli-user starts Phase 2 seed expansion at the new path. @opencli-user and I drafted a 21-site Tier 1 list + claim protocol in the design thread (#OpenCLI:3e19f061), pending @WAWQAQ pace/breadth/parallelism call.
Test plan
npm run docs:buildcleanvitest run src/cli.test.ts -t "resolveSitemapAvailabilityForUrl"— 3 tests pass