Use constants for test options

[jakeboone02]

Summary by CodeRabbit

• Tests
  • Expanded coverage for currency and percentage formatting combinations.
  • Added validation for invalid repeated-percentage configurations.
  • Improved BigInt overflow and Roman numeral test coverage.
  • Standardized test options for more consistent results.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 65198ae5-3ed7-4216-95a4-d9806e51238f

📥 Commits

Reviewing files that changed from the base of the PR and between a02e223 and 6f336d6.

📒 Files selected for processing (1)

• src/numericQuantityTests.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

Numeric quantity test coverage

Layer / File(s)	Summary
Shared test options src/numericQuantityTests.ts	Shared constants replace repeated BigInt overflow, currency, and Roman numeral option literals.
Currency affix coverage src/numericQuantityTests.ts	Currency tests add affix ordering, spacing, and repeated-percent invalid-input cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6f336

This is a localized test-only refactor to use constants for test options, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: replacing repeated test option literals with shared constants.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test-pr

---

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

bun add https://pkg.pr.new/numeric-quantity@47

npm i https://pkg.pr.new/numeric-quantity@47

pnpm add https://pkg.pr.new/numeric-quantity@47

commit: 6f336d6

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a02e223) to head (6f336d6).

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          464       464           
=========================================
  Hits           464       464           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.