Merging of lite and master branch

[Fly7113]

As of now it's clear that both versions of Bitwarden - "classic" and lite - are here to stay.
I noticed that the licenseGen code is the same across the two branches, and it's not unheard of that they can get out of sync.

Considering the above reasons, and others, I've been thinking to propose merging our two branches into a single one. This way the common code will be easier and faster to update.
For ease of maintainability I'd of course keep the files separate and organised, but I'd surely like to overhaul the shell script(s) into a single more robust one.

I would welcome the consensus of the maintainers and the community on this matter before beginning the work.

[Fly7113]

CC: @captainhook @h44z @GieltjE @Jgigantino31

[captainhook]

Agreed - I don't think there's any reason to have them separate and I don't think that's 'proper' use of git branches anyway.

Happy to review this and provide any Copilot reviews to help along the way. Is lite branch in good working order? @GieltjE if it is, I could assign this issue to Copilot and it can perhaps help save some time by doing a bunch of the leg work. Let me know what you think.

[GieltjE]

Currently working on a new set of fixes as it cannot patch the latest versions. (If anyone has some insights....).

The licensegen overlaps (mostly?), how do we want to manage the other code?

[Fly7113]

I think it's better to wait for a stable lite branch before beginning the transition.

As for the organisation of the code: I think something as simple as having two src/bitBetter subfolders, one for the standard and one for the lite version, is more than enough. I'd keep two different images to have them as light as possible, and as separate as possible so to have at least a working version if one of the two stops working in an update.

[GieltjE]

Most scripts are very different between both branches, the src/bitBetter is the most 1:1.
Reworked all files and logic quite a bit when I made the lite branch.

[Fly7113]

The scripts surely need a big rewrite.
The thing I was proposing was to merge, where possible, all the various scripts (build.sh, update-bitwarden.sh, source/bitBetter/build.sh, source/licenseGen/build.sh and source/licenseGen/run.sh for the main branch, and build.{sh,ps1}, generateKeys.{sh,ps1} and licenseGen.{sh,ps1} for the lite branch) into a single one (e.g. bitbetter.{sh,ps1} or something along those lines), in a way that all possible operations are tackled by a single more user-friendly script.
For example, one thing that I'd really push for is the support for autocompletion and editing of the text inputted in the scripts, and a more robust detection of the cert files.

[h44z]

I also support merging the two branches once the lite branch is up to date, since that should make future development easier.
We just need to ensure the documentation clearly explains how to use BitBetter for the different installation variants going forward ( e.g. we should create two entirely new update/build scripts so there is no risk of accidentally calling an outdated/wrong script).

[Fly7113]

Excellent.
At this point we'll wait for @GieltjE's signals about his work on the lite branch and then get on with this proposal 🚀

[GieltjE]

Unfortunately life is very busy, if anyone has some spare time, please take a look at my fork.

Are we planning on merging the build scripts or keep separate ones for each type?

[Fly7113]

No rush at all 🫶 and I'll see if I can help.
I'd be against having multiple scripts: just a single one with all the required functions should do the trick pretty easily, and it's less confusing than having multiple scripts laying around.

[GieltjE]

Created pull request #280, this fixes the issues with the latest Lite branch.

I don't mind merging, though at this point both approaches are very different in structure.

There has been considerable time spent from my side in order to create both Linux and Windows scripts that are functionaly identical, new flows and loads of small fixes.
Please do not throw this work away by using some "ai" in order to quickly merge them.