Skip to content

Fix intent check bypassed due to init setting - #215

Open
inDream wants to merge 1 commit into
jakiestfu:v2.0.0-rc1from
inDream:fixIntent
Open

Fix intent check bypassed due to init setting#215
inDream wants to merge 1 commit into
jakiestfu:v2.0.0-rc1from
inDream:fixIntent

Conversation

@inDream

@inDream inDream commented Jun 28, 2014

Copy link
Copy Markdown

Currently hasIntent part of dragging would never entered as hasIntent is undefined.

@ronmichael

Copy link
Copy Markdown

I ran into this too. Although I went with a different solution: around like 511 I replaced

       if (cache.hasIntent === false || cache.hasIntent === null) 

with

       if (!cache.intentChecked)

@inDream

inDream commented Oct 27, 2014

Copy link
Copy Markdown
Author

Both solution work, but I think it's better to set an init value for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants