Add missing Makefile.in files from Opus distribution#3488
Merged
pljones merged 1 commit intojamulussoftware:mainfrom Apr 9, 2025
Merged
Add missing Makefile.in files from Opus distribution#3488pljones merged 1 commit intojamulussoftware:mainfrom
pljones merged 1 commit intojamulussoftware:mainfrom
Conversation
Two instances of Makefile.in were accidentally omitted due to a rule in .gitignore. Also update .gitignore not to ignore them.
Collaborator
|
Should we build the OPUS library using its own build system, rather than using Jamulus.pro directly? Is there a platform-independent way to do that? (That's where including it in Jamulus.pro is most likely to be the best way, I guess...) |
Member
Author
Certainly worth exploring, although I don't know how platform independent the configure stuff is. But getting these missing files in, that were overlooked in #3409 is an essential first step. |
pljones
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Two instances of
Makefile.inwere accidentally omitted from the Opus sources in #3409 due to a rule in.gitignore.This commit also updates
.gitignorenot to ignore them.Makefile.inis not required when building Jamulus fromJamulus.pro, but is needed if experimenting with./configurein the Opus directory to try out new configuration options.CHANGELOG: Internal: Add missing Makefile.in files to Opus 1.5.2 distro.
Context: Fixes an issue?
No, but was discovered while reviewing #3487
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready to merge. No effect on current builds.
What is missing until this pull request can be merged?
Only review
Checklist