Skip to content

mono - upgrading vitest, faker, biome, and types #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredwray merged 1 commit into from
Apr 9, 2026
+628 −386
Merged

mono - upgrading vitest, faker, biome, and types #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@
"author": "Jared Wray <me@jaredwray.com>",
"license": "MIT",
"devDependencies": {
"@biomejs/biome": "^2.4.4",
"@faker-js/faker": "^10.3.0",
"@types/node": "^25.3.0",
"@vitest/coverage-v8": "^4.0.18",
"@vitest/spy": "^4.0.18",
"@biomejs/biome": "^2.4.10",
"@faker-js/faker": "^10.4.0",
"@types/node": "^25.5.2",
"@vitest/coverage-v8": "^4.1.3",
"@vitest/spy": "^4.1.3",
Comment on lines +25 to +26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Vitest and its associated plugins (like @vitest/coverage-v8 and @vitest/spy) are tightly coupled and often require exact version matches for their peer dependencies to function correctly. Using caret ranges (^4.1.3) can lead to peer dependency conflicts if one package is updated independently of the others. It is recommended to use exact versions for these dependencies to ensure stability across the monorepo.

Suggested change
"@vitest/coverage-v8": "^4.1.3",
"@vitest/spy": "^4.1.3",
"@vitest/coverage-v8": "4.1.3",
"@vitest/spy": "4.1.3",

"rimraf": "^6.1.3",
"vitest": "^4.0.18",
"vitest": "^4.1.3",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

vitest@4.1.3 specifies vite as a peer dependency (^6.0.0 || ^7.0.0 || ^8.0.0). While it is currently being resolved transitively in the lockfile (to 7.3.1), it is best practice to explicitly list vite in your devDependencies to ensure consistent resolution and to have direct control over its version. Additionally, using an exact version for vitest is recommended to match its plugins.

Suggested change
"vitest": "^4.1.3",
"vite": "7.3.1",
"vitest": "4.1.3",

"wrangler": "^4.68.1"
},
"pnpm": {
Expand Down
Loading
Loading