Skip to content

Fix timezone-dependent getDate timestamp test #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohammedAlkindi wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

Fix timezone-dependent getDate timestamp test #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Here is a list of past and present much-appreciated contributors:
Matthew Hegarty
Matthias Dellweg
Mike Waldner
Mohammed Alkindi
Nicholas Pilon
Peyman Salehi
Rabin Nankhwa
Expand Down
7 changes: 6 additions & 1 deletion tests/test_tablib_dbfpy_packages_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ def test_getDate_datetime_timestamp(self):

# Assert
self.assertIsInstance(output, dt.date)
self.assertEqual(output, dt.date(2019, 10, 19))
# getDate converts a number with datetime.fromtimestamp(), which uses
# the local timezone. This timestamp is 2019-10-19 20:01:46 UTC, so
# east of UTC+3:58 the local date is already 2019-10-20 — a hardcoded
# date makes the test fail for any contributor in those timezones.
# Assert the documented contract instead of one timezone's rendering.
self.assertEqual(output, dt.date.fromtimestamp(value))

def test_getDate_datetime_string_yyyy_mm_dd(self):
# Arrange
Expand Down