Merged
Conversation
Updated the wikitext_simplified dependency to the latest version which introduced the Spanned<T> wrapper type for nodes to include source location information. Made the following changes: - Updated Cargo.lock with new wikitext_simplified commit (e637ff1b) - Added Spanned and Span imports to both main.rs and template.rs - Created helper function spanned() to wrap nodes with default spans - Updated pattern matching to access .value field on Spanned nodes - Modified children vectors to use Vec<Spanned<WikitextSimplifiedNode>> - Updated function signatures to handle Spanned types correctly - Fixed all compilation errors related to the API changes All tests pass successfully.
Created a new util module to hold common helper functions and moved the spanned helper there, renaming it to empty_spanned for clarity. Changes: - Created src/util.rs with empty_spanned() function - Updated main.rs to import and use empty_spanned from util - Updated template.rs to import and use empty_spanned from util - Removed duplicate spanned() definitions from both files - Removed unused Spanned import from template.rs This reduces code duplication and provides a central location for common utility functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the wikitext_simplified dependency to the latest version which introduced the Spanned wrapper type for nodes to include source location information.