fix: preserve hyperindex connection bonds in gate_inds_with_tn#362
Open
JiwaniZakir wants to merge 1 commit into
Open
fix: preserve hyperindex connection bonds in gate_inds_with_tn#362JiwaniZakir wants to merge 1 commit into
JiwaniZakir wants to merge 1 commit into
Conversation
When the target index is a hyperindex, its replacement rand_uuid appears as an inner index in tn_target. If the gate's inner index is also shared across multiple tensors, the same rand_uuid becomes inner in both networks, causing add_tensor_network's collision check to mangle it and disconnect the result. Fix by explicitly excluding the intentional connection bonds from the clash set before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
gate_inds_with_tn, when a target index is a hyperindex (appears in 3+ tensors), the connection bond is classified as an inner index in both networks, causing the collision check to mangle it. The fix excludes intentional connection bonds before renaming, then merges withcheck_collisions=False. A test with a hyperindex target and a gate spanning two tensors is added. Fixes #319