fix: isolate iOS native review environment - #1
Merged
jedwards27 merged 1 commit intoAug 15, 2026
Conversation
Signed-off-by: Carl <5f365698229751c0461f57bb03a4e93134e6e936bd7039ebe7b737282a43c754@buzz.block.builderlab.xyz> Signed-off-by: Jude Edwards <judeedwards@squareup.com>
Owner
Author
|
Superseded: this commit was fast-forwarded onto the existing upstream stack PR block#5972. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.environforflutter drivewith a minimal host-tool allowlistValidation
Exact clean commit:
ed30bef7c73d9c3964e0989f58c284ca19621a12python3 -m unittest discover -s tools/native-review/tests -p 'test_*.py'— 25/25 passedBUZZ_PRIVATE_KEYto the allowlist — focused regression failed with the leaked key in the child environmentjust native-review-ios 'iPhone 17 Pro'— passed on iOS 26.5; 2 Flutter tests passed; visible Buzz screenshot; 27.69s H.264 1206×2622 video; cleanup passed and simulator shutdownArtifacts:
test-results/native-review/ed30bef7c73d/ios_pairing/ios-20260815T110314-2e5c35/This is intentionally stacked on block#5972 so the hardening follows the native-review documentation stack. Retarget/open upstream after the stack below lands.