Skip to content

Use script.remove instead of removeChild for unity loader hook #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffreylanters merged 3 commits into from
May 15, 2025
Merged

Use script.remove instead of removeChild for unity loader hook #576

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea30505
script remove
alexqhj Feb 25, 2025
e74ceb3
remove old oops
alexqhj Feb 26, 2025
91235fa
fix
alexqhj Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions module/source/hooks/use-unity-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ const useUnityLoader = (unityConfig: UnityConfig): UnityLoaderStatus => {
// this scenario, the window is not available. We can't create a Unity
// Loader in this case.
if (isBrowserEnvironment === false) {
return;
return undefined;
}
// If the script's source is null, we'll reset the status to idle.
if (unityConfig.loaderUrl === null) {
setStatus(UnityLoaderStatus.Idle);
return;
return undefined;
}
/**
* Find existing script element by source. It may have been added by
Expand Down Expand Up @@ -78,7 +78,7 @@ const useUnityLoader = (unityConfig: UnityConfig): UnityLoaderStatus => {
if (script !== null) {
script.removeEventListener("load", setStateFromEvent);
script.removeEventListener("error", setStateFromEvent);
window.document.body.removeChild(script);
script.remove();
}
};
}, [unityConfig.loaderUrl]);
Expand Down
Loading