Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Enforce get method for validation checks#5

Open
miglen wants to merge 1 commit intojenkinsci:masterfrom
miglen:checkmethod-get
Open

Enforce get method for validation checks#5
miglen wants to merge 1 commit intojenkinsci:masterfrom
miglen:checkmethod-get

Conversation

@miglen
Copy link
Copy Markdown

@miglen miglen commented Jun 17, 2021

The following change enforces the use of get in the form validation instead of post which was recently introduced by default and it's breaking the plugin functionality.

  • [ X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [ X] Ensure that the pull request title represents the desired changelog entry
  • [ X] Please describe what you did
  • [ X] Link to relevant issues in GitHub or Jira
  • [ X] Link to relevant pull requests, esp. upstream and downstream changes
  • [ X] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Related issue: https://issues.jenkins.io/browse/JENKINS-65790

@miglen
Copy link
Copy Markdown
Author

miglen commented Jun 17, 2021

Ping @yyuu @asfaltboy

@sabberworm
Copy link
Copy Markdown

sabberworm commented Jun 30, 2021

Wouldn’t it be better to enforce POSTs and switch the endpoints in rack.rb?

@miglen
Copy link
Copy Markdown
Author

miglen commented Jun 30, 2021 via email

@sabberworm
Copy link
Copy Markdown

For future reference, the change that caused this regression is at jenkinsci/jenkins#4623

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants