Added a scriptable option for selecting Unity installation

[tommikiviniemi-srs]

Can use environment and build variables, instead of selecting from a static drop-down box. Should still point to a name in the global Unity3d installations. Standard behaviour until used.

[Brantone]

To a certain extent, isn't this already available by defining a Unity installation with:
Name = "Mac Unity Version Param Install"
Installation directory = "/Applications/${unity_version_dirname}/Unity.app"

And as long as the job has "unity_version_dirname", then it will expand that variable.

I know this works (as currently using it), curious what else this PR is adding ... (macro?)

[tommikiviniemi-srs]

Hi,

We use a Groovy script to dynamically create the define, say
${UNITY_INSTALLATION}, inside the build job.
The vanilla version of the plugin only allows to pick from an existing
name, and IIRC does not expand the name, so doing something like
map["UNITY_INSTALLATION"] = "path"
does not work. I can't remember the exact specifics anymore but I am 100%
certain I tried to make a "dummy" installation inside generic Jenkins
settings and overriding it as explained, but it did not expand it properly.
So the extension allows for dynamically defining installation paths at
runtime via Groovy.

• Tommi

On Sat, Jun 4, 2016 at 12:13 AM, Brenton B notifications@github.com wrote:

To a certain extent, isn't this already available by defining a Unity
installation with:
Name = "Mac Unity Version Param Install"
Installation directory = "/Applications/${unity_version_dirname}/Unity.app"

And as long as the job has "unity_version_dirname", then it will expand
that variable.

I know this works (as currently using it), curious what else this PR is
adding ... (macro?)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AG88aJ3hRbRIUe0xpjE9i4RqkYyxDCHpks5qIJkJgaJpZM4IKtTk
.

[Brantone]

I haven't tried using "Inject Env Vars" in conjunction with Unity3d yet, but we have a setup operating in production that takes in a parameter for the Unity version, then the unity3d plugin itself has the named install directory using that parameter ... and it works. Mind you, this is a fairly simple setup.

[monsieurh]

That would be something we direly need too. Is this still functioning ? I tried to reproduce @Brantone setup to no avail. Did you use "Inject Env Vars" to make it work ?

[tommikiviniemi-srs]

Hi @monsieurh. We still use the patched version daily, but I haven't updated the Unity3d plugin in ages because the pull request was not accepted.

…

On Mon, Jun 24, 2019 at 4:40 PM monsieurh ***@***.***> wrote: That would be something we direly need too. Is this still functioning ? I tried to reproduce @Brantone <https://github.com/Brantone> setup to no avail. Did you use "Inject Env Vars" to make it work ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7?email_source=notifications&email_token=ABXTY2CEVGFFXSDDHKSWVFDP4DFFVA5CNFSM4CBK2TSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYM6RWA#issuecomment-505014488>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXTY2FW5VDAGNRNRJUF7C3P4DFFVANCNFSM4CBK2TSA> .

[tommikiviniemi-srs]

Any chance of accepting this pull request?

It makes the Unity installation scriptable by accepting environment variables. There seems to be quite a few people needing this behaviour.