fix: correct error type assertion in example for ErrHelp check#429
Open
Yanhu007 wants to merge 1 commit into
Open
fix: correct error type assertion in example for ErrHelp check#429Yanhu007 wants to merge 1 commit into
Yanhu007 wants to merge 1 commit into
Conversation
The example uses a type switch on flags.ErrorType (an int type alias), but parser.Parse() returns *flags.Error (a struct pointer). The type assertion never matches, so -h/--help always exits with status 1 instead of 0. Fix by switching on *flags.Error and checking flagsErr.Type. Fixes jessevdk#425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #425
Problem
The example
main.gouses an incorrect type assertion:But
parser.Parse()returns*flags.Error(a struct pointer), notflags.ErrorType. The type switch never matches, so-h/--helpalways falls through toos.Exit(1).Fix
This matches the actual error type and correctly checks the
.Typefield.