Skip to content

getUsers() for api version 2 #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

getUsers() for api version 2 #362

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89d2dca
Update jira.js
Just-Web-Developer May 30, 2023
0ac0193
Update jira.js
Just-Web-Developer Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/jira.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,10 +829,11 @@ export default class JiraApi {
*/
getUsers(startAt = 0, maxResults = 100) {
return this.doRequest(this.makeRequestHeader(this.makeUri({
pathname: '/users',
pathname: this.apiVersion === '2' ? '/user/search' : '/users',
Copy link
Contributor

@Seth10001 Seth10001 Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rest/api/2/user/searh appears to be an alias for /rest/api/2/users: https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-users/#api-rest-api-2-users-get

This change shouldn't be needed? Could you provide some more context?

Copy link
Author

@Just-Web-Developer Just-Web-Developer Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rest/api/2/users doesn't worked for a local copy of Jira, but /rest/api/2/user/searh worked well. Now, I checked it with cloud Jira and got the opposite result, /rest/api/2/user/searh doesn't work but /rest/api/2/users do. Maybe it would be usefull to add an additional parameter that would indicate whether the request sent to a local Jira or not.

query: {
startAt,
maxResults,
...(this.apiVersion === '2' ? {username: '.', includeInactive: 'true'} : {})
},
})));
}
Expand Down