Remove jito-bytemuck, jito-account-traits-derive#270
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the in-repo jito-bytemuck and jito-account-traits-derive workspace crates and switches the workspace to consume those crates from GitHub instead, updating build/codegen and release workflows accordingly.
Changes:
- Drop
account_traits_derive/andbytemuck/from the workspace and remove their source files/manifests. - Update workspace dependencies to pull
jito-account-traits-deriveandjito-bytemuckfrom git tags, and refreshCargo.lock. - Update make/codegen and GitHub Actions publishing/CI workflows to stop referencing the removed workspace crates.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| makefile | Removes bytemuck from Shank module paths during IDL generation. |
| bytemuck/src/types.rs | Deletes the local jito-bytemuck implementation (types + tests). |
| bytemuck/src/lib.rs | Deletes the local account deserialization traits module. |
| bytemuck/Cargo.toml | Removes the local jito-bytemuck crate manifest. |
| account_traits_derive/src/lib.rs | Removes the local AccountDeserialize proc-macro implementation. |
| account_traits_derive/Cargo.toml | Removes the local proc-macro crate manifest. |
| Cargo.toml | Removes the two crates from workspace members; switches both deps from path to git. |
| Cargo.lock | Updates lockfile for git-sourced crates (currently includes duplicate sources for jito-account-traits-derive). |
| .github/workflows/publish-crates.yaml | Removes the deleted crates from publish ordering/default list and normalizes YAML quoting/whitespace. |
| .github/workflows/publish-crate.yaml | Removes the deleted crates from selectable publish options (but leaves an invalid default). |
| .github/workflows/ci.yaml | Normalizes YAML quoting; adds a Rust toolchain setup for the audit job; updates cargo-audit version and ignore list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ebatsell
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.