Skip to content

Fix dialyzer - #37

Open
meox wants to merge 2 commits into
jlouis:masterfrom
athonet-open:fix-dialyzer
Open

Fix dialyzer#37
meox wants to merge 2 commits into
jlouis:masterfrom
athonet-open:fix-dialyzer

Conversation

@meox

@meox meox commented Dec 3, 2021

Copy link
Copy Markdown

fix dialyzer spec in order to be consistent with the fuse module

@meox

meox commented Dec 9, 2021

Copy link
Copy Markdown
Author

any hope to have this one merged?

1 similar comment
@meox

meox commented Dec 17, 2021

Copy link
Copy Markdown
Author

any hope to have this one merged?

@paulo-ferraz-oliveira

Copy link
Copy Markdown
Contributor

@meox: what version of OTP are you running this under? Under 22.3.4.23, 23.3.4.9, and 24.1, at least, I'm unable to find dialyzer issues by executing rebar3 dialyzer directly on the lib. (I imagine the issues might be coming from consumption by another lib./app.).

Also, you could/should add your checks to the GitHub action so that whatever issue is arising is not introduced again, in the future.

Note: I'm not the lib.'s maintainer.

@meox

meox commented Dec 18, 2021

Copy link
Copy Markdown
Author

The problem rise when you use the library from your application. In particular when you use a term instead of a simple atom.
For now I have forked the repo but I'm wondering if there is the possibility to have this merged in the main repo so I can drop my fork.

@paulo-ferraz-oliveira

Copy link
Copy Markdown
Contributor

I see.

You're calling an API that's calling those functions internally, is it? And this is what's causing the issue?

Yeah, I believe some change will come of this, either being more restrictive (moving term() to atom(), thus "breaking" the interface - it doesn't, it'll just break analysis) or accepting as you're proposing.

@meox

meox commented Jan 8, 2022

Copy link
Copy Markdown
Author

in my mind an atom is too restrictive because otherwise we end up to call too many times functions like list_to_atom or similar

@meox

meox commented Jan 23, 2022

Copy link
Copy Markdown
Author

@jlouis can you take a look of this pr?
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants