Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operators currently need direct server/database access to investigate production failures. This adds an opt-in, machine-only diagnostics API for bounded sanitized log search and masked database inspection across explicitly authorized tenants.
This PR is stacked on #274 (
codex/workspace-messaging-roles); its diff contains only the diagnostics batch.Changes
Local verification
Backend commands ran against an isolated snapshot of this branch in the existing backend container, using only disposable test databases:
python manage.py test core.diagnostics.tests --settings=core.diagnostics.test_settings --noinput— 23 passed; four new regression cases reproduced the reviewed defects before fixes.python manage.py test core.diagnostics.test_postgres --settings=core.diagnostics.postgres_test_settings --noinput— 6 passed, including real privilege denial, indirect tenant ownership, masking, timeout, pagination and unsafe inherited grants.python3 -m unittest discover -s scripts/tests -p test_diagnostics_helper.py -v— 5 passed.python manage.py spectacular --settings=core.diagnostics.test_settings --file /tmp/eceee-diagnostics-pr-schema.yaml --validate --fail-on-warn— passed.git diff --check— passed.Risk and rollout
This requires careful review of new diagnostic authorization, cross-tenant selection and PostgreSQL role/view provisioning. It adds no application-data migration or backfill. Access is disabled by default; production credentials, views, host timer installation and enabling the feature require separate owner gates. No production reads, provisioning or deployment have been performed. The Linux timer has been statically checked but not exercised on the production host.
A full local backend Django run passed 1,639 tests (18 skipped) on the current backend-editor image. The initial older-image attempt lacked ffmpeg; no product fix was needed for that environment issue. Frontend suites were not repeated because no frontend behavior changed; their prior Full CI evidence remains separate. Full CI is requested again for the updated authorization/database/deployment surface. This PR is worth a full CI run. CI results are verification, not code-review approval or merge authorization.
Review fixes
All four findings were P2 and have focused reproductions. Final independent review and current-head CI are reported separately from code-review/merge authorization.