Closed
Conversation
We want Scala 3.7. compatible code emitted by the code generation in order to be able to migrate to Scala 3.7. in downstream projets. These are the necessary adjustments.
Contributor
Author
|
To add a little more context: |
mpollmeier
requested changes
Mar 27, 2026
| case "L1" => _.out // -> L2 | ||
| case "R1" => _.repeat(_.out)(_.maxDepth(3)) // -> R4 | ||
| case "L1" => _.out // -> L2 | ||
| case "R1" => _.repeat(_.out)(using _.maxDepth(3)) // -> R4 |
Contributor
There was a problem hiding this comment.
this uglyfies the traversal DSL - albeit in a rarely used path and it was built onto a hack, but still... we should at least look for alternative ways do keep the nice dsl before throwing it over board
| ThisBuild / scalaVersion := scala3 | ||
|
|
||
| val scala3 = "3.3.6" | ||
| val scala3 = "3.7.4" |
Contributor
There was a problem hiding this comment.
See the comment below this line - this is a library and as such should always stay on the current scala LTS release, which currently is 3.3.7
Contributor
Author
|
Makes sense. Will make a new PR with only the changes to make it 3.7. compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want Scala 3.7. compatible code emitted by the code generation in
order to be able to migrate to Scala 3.7. in downstream projets.
These are the necessary adjustments.