Change Holo dialogs to Material#270
Open
NBonaparte wants to merge 2 commits intojonan:masterfrom
Open
Conversation
jonan
requested changes
Mar 29, 2017
Owner
jonan
left a comment
jonan
left a comment
There was a problem hiding this comment.
I've tried this changes in API 19 and dialogs are not rendered properly.
Need to check with API >= 21 yet.
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) | ||
| return new LightAlertDialog(context, Theme_Material_Light_Dialog_Alert); | ||
| else | ||
| return new LightAlertDialog(context, Theme_Holo_Light_Dialog); |
Owner
There was a problem hiding this comment.
This two calls should be new LightAlertDialog.Builder(...)
| import android.content.Context; | ||
| import android.os.Build; | ||
|
|
||
| import static android.R.style.Theme; |
Contributor
|
@jonan Are you working on this? if not I can make the necessary changes suggested by you and raise a PR. |
Contributor
Author
|
Sorry it's been a while, I just added the requested changes. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows Material dialogs to be used if available (running Lollipop or above), while maintaining support for API < 21.
THEME_HOLO_LIGHTis also apparently deprecated, so it has been replaced.