fix: guard husky prepare script for non-dev installs#26
Closed
dstude wants to merge 1 commit intojrenaldi79:mainfrom
Closed
fix: guard husky prepare script for non-dev installs#26dstude wants to merge 1 commit intojrenaldi79:mainfrom
dstude wants to merge 1 commit intojrenaldi79:mainfrom
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users install sidecar globally via:
npm runs the
preparescript as part of installation. Sincehuskyis a devDependency, it isn't present in a global install context — causing the install to fail immediately with a missing module error, before sidecar is usable at all.Fix
Guard the
preparescript so husky only runs when inside a git checkout:This means:
.gitdir): the script exits cleanlyThis is the standard pattern recommended for projects that support both development and end-user installs. No behavior change for contributors.