Type choice enhancements#7
Open
dpellegr wants to merge 1 commit into
Open
Conversation
All signed ints has been converted to unsigned long. This is logically appropriate as timers and counters should never go negative. In addition it also suppresses some compiler warning (-Wsign-compare). I suspect that the original choice was motivated by the special values NEOTIMER_INDEFINITE and NEOTIMER_UNLIMITED. These have been adjusted to the maximum allowable value for the unsigned long type by replacing the #define statement with constexpr.
|
This is correct, I suggest using this file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All signed ints has been converted to unsigned long.
This is logically appropriate as timers and counters should never go negative.
In addition it also suppresses some compiler warning (-Wsign-compare).
I suspect that the original choice was motivated by the special values NEOTIMER_INDEFINITE and NEOTIMER_UNLIMITED. These have been adjusted to the maximum allowable value for the unsigned long type by replacing the #define statement with constexpr.