This repository was archived by the owner on Jan 9, 2019. It is now read-only.
Add unittest for #62#63
Open
yohanboniface wants to merge 4 commits into
Open
Conversation
Owner
|
Oh it looks like this identified another path the tests are missing. I (or @cvan) can take some time to fix that up and get this in, but it'll probably be a little while. |
Contributor
Author
|
Shouldn't we just add GitPython in the requirements? Or are you referring to another issue? |
Owner
|
Yes, I'm just curious if that's going to open a can of worms because this is a pretty significant area of code that has apparently never been hit by tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure it's worth it, but now it's done ;)
I've added a hard coded
JAVA_BIN=javathroughoverride_settings, which is not that elegant, but I've had no better idea (unless mocking).Also, to make the tests runs, I've tweaked a little bit the settings (but not pushed) for django 1.6:
STATIC_URLmissing a final /, added a missingSECRET_KEY, this kind of things. Not sure how you run your tests though ;)Thanks :)
Yohan