Skip to content

test: remove date format cases#900

Merged
jdesrosiers merged 1 commit into
json-schema-org:mainfrom
AcEKaycgR:exhaustive-date-suite
May 20, 2026
Merged

test: remove date format cases#900
jdesrosiers merged 1 commit into
json-schema-org:mainfrom
AcEKaycgR:exhaustive-date-suite

Conversation

@AcEKaycgR
Copy link
Copy Markdown
Contributor

Summary

This PR removes four duplicate date tests in draft-v1, draft-07, draft/2019-09, and draft/2020-12. These tests are already covered by other cases in the suite.

Changes

  • Remove 2021-02-29: This is already tested by "2021 is not a leap year".
  • Remove 2020-02-29: This is already tested by "2020 is a leap year".
  • Remove 2020-13-01: This is already tested by "invalid month".
  • Remove 1998-04-31: This is already tested by "31 days in April".

Notes

@jviotti @jdesrosiers @karenetheridge This PR only handles the removal of duplicates.

@AcEKaycgR AcEKaycgR requested a review from a team as a code owner May 14, 2026 15:18
Copy link
Copy Markdown
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I agree the tests you removed where not testing anything new in comparison to the rest

@jdesrosiers jdesrosiers merged commit ba30ec7 into json-schema-org:main May 20, 2026
3 checks passed
@AcEKaycgR AcEKaycgR deleted the exhaustive-date-suite branch May 21, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants