Make loadbalancer account for master instance type#545
Open
lseek wants to merge 4 commits intojtriley:developfrom
Open
Make loadbalancer account for master instance type#545lseek wants to merge 4 commits intojtriley:developfrom
lseek wants to merge 4 commits intojtriley:developfrom
Conversation
added 4 commits
July 28, 2015 12:31
The load balancer currently assumes that all nodes in a cluster (including the master node) are of the same instance type and throws an exception if this is not so. But the StarCluster config explicitly allows the master node to be of a different instance type than its execution hosts. Therefore if a cluster is configured in such a manner the loadbalancer will fail to run. This commit makes the loadbalancer take into account that the master node can be of a different instance type.
The load balancer currently assumes that all nodes in a cluster (including the master node) are of the same instance type and throws an exception if this is not so. But the StarCluster config explicitly allows the master node to be of a different instance type than its execution hosts. Therefore if a cluster is configured in such a manner the loadbalancer will fail to run. This commit makes the loadbalancer take into account that the master node can be of a different instance type.
Initialize 'master' variable in loadbalancer's slots_per_host method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The load balancer currently assumes that all nodes in a cluster
(including the master node) are of the same instance type and throws an
exception if this is not so. But the StarCluster config explicitly
allows the master node to be of a different instance type than its
execution hosts. Therefore if a cluster is configured in such a manner
the loadbalancer will fail to run.
This commit makes the loadbalancer take into account that the master
node can be of a different instance type.