display exceptions in threadpool, and look for 'mpich', not 'mpich2'#548
Open
rustandruin wants to merge 1 commit intojtriley:developfrom
Open
display exceptions in threadpool, and look for 'mpich', not 'mpich2'#548rustandruin wants to merge 1 commit intojtriley:developfrom
rustandruin wants to merge 1 commit intojtriley:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
The mpich2 plugin searches for 'mpich2' in the output of 'update-alternatives --list mpirun' to find the location of the mpich2 path, but in Ubuntu 15.04, the command name is mpirun.mpich to run mpich2, so the search fails and causes an error. I changed the search for the more general 'mpich'
To facilitate debugging of plugins, prints the exceptions that arise in running a threadpool before raising a threadpool exception (the latter is not verbose enough in its output). I find this useful for seeing exactly what the commandline was in a node.ssh.execute command that failed during the run of a plugin.