Add volumes input for mounting host directories into the Firebird container#12
Merged
Conversation
… container Agent-Logs-Url: https://github.com/mariuz/firebirdsql-github-action/sessions/f2e39215-3b7b-47c9-b089-1ff5f0f81482 Co-authored-by: mariuz <18359+mariuz@users.noreply.github.com>
…ests Add `volumes` input for mounting host directories into the Firebird container
Contributor
Author
|
related issue #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users needed a way to mount host filesystem paths into the Firebird Docker container to access
.fdbfiles directly from the host — previously only achievable by running Docker manually.Changes
action.yml— Newvolumesinput accepting newline-separatedhost_path:container_pathmappingsentrypoint.sh— ParsesINPUT_VOLUMESand appends--volumeflags to thedocker runinvocationtesting.sh— Added volume test loop: starts container with a mapped volume, queries the DB, asserts the.fdbfile is visible on the hosttesting_changes.yml— Newci-volumesjob testing volume mounting across Firebird versionslatest,5,4,3; verifies the database file lands on the host pathREADME.md— Documents the new parameter and adds it to the usage exampleUsage
The host directory must exist and be writable before the action runs (e.g.
sudo mkdir -p /tmp/firebird-data && sudo chmod 777 /tmp/firebird-data). Multiple volumes are supported — one per line.