Skip to content

docs+runtime: warn against mounting volumes under $GITHUB_WORKSPACE#15

Merged
juarezr merged 2 commits into
juarezr:masterfrom
mariuz:master
Apr 23, 2026
Merged

docs+runtime: warn against mounting volumes under $GITHUB_WORKSPACE#15
juarezr merged 2 commits into
juarezr:masterfrom
mariuz:master

Conversation

@mariuz
Copy link
Copy Markdown
Contributor

@mariuz mariuz commented Apr 21, 2026

Mounting a volume host-path under ${{ github.workspace }} breaks silently: actions/checkout (default clean: true) runs after this action in the typical workflow order and wipes the workspace, destroying the mount point while the Firebird container keeps running against a now-missing directory. This was the root cause of mapped-filesystem test failures observed in the Jaybird CI.

Changes

  • README.md — added a [!WARNING] callout under the volumes parameter:

    • Explains the checkout-order hazard

    • Recommends ${{ runner.temp }} (job-scoped, never touched by checkout) as the correct host path

    • Includes a ready-to-use workflow snippet:

      - uses: juarezr/firebirdsql-github-action@v2
        with:
          volumes: '${{ runner.temp }}/firebird-data:/var/lib/firebird/data'
      - uses: actions/checkout@v4
      - name: Run tests
        run: ./gradlew test -Ptest.db.mapped=${{ runner.temp }}/firebird-data
  • entrypoint.sh — non-fatal runtime warning when a volume host-path begins with $GITHUB_WORKSPACE/ (slash-bounded to avoid false-positives on sibling directories):

    ## WARNING: Volume host path '...' is inside $GITHUB_WORKSPACE.
    ## WARNING: If actions/checkout runs after this step (default), it will delete
    ## WARNING: the workspace directory (clean: true), breaking the volume mount.
    ## WARNING: Use ${{ runner.temp }} instead to avoid this problem.
    

Copilot AI and others added 2 commits April 21, 2026 10:18
docs+runtime: warn against mounting volumes under $GITHUB_WORKSPACE
@juarezr juarezr merged commit 77b0bb3 into juarezr:master Apr 23, 2026
13 checks passed
mrotteveel added a commit to FirebirdSQL/jaybird that referenced this pull request May 4, 2026
mrotteveel added a commit to FirebirdSQL/jaybird that referenced this pull request May 4, 2026
@mrotteveel
Copy link
Copy Markdown

I tried the change as suggested here, but it didn't work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants