docs+runtime: warn against mounting volumes under $GITHUB_WORKSPACE#15
Merged
Conversation
Agent-Logs-Url: https://github.com/mariuz/firebirdsql-github-action/sessions/5e8a36d9-221b-4c97-8b33-20f4fd4e2495 Co-authored-by: mariuz <18359+mariuz@users.noreply.github.com>
docs+runtime: warn against mounting volumes under $GITHUB_WORKSPACE
mrotteveel
added a commit
to FirebirdSQL/jaybird
that referenced
this pull request
May 4, 2026
mrotteveel
added a commit
to FirebirdSQL/jaybird
that referenced
this pull request
May 4, 2026
This reverts commit 3e9a79f.
|
I tried the change as suggested here, but it didn't work for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mounting a volume host-path under
${{ github.workspace }}breaks silently:actions/checkout(defaultclean: true) runs after this action in the typical workflow order and wipes the workspace, destroying the mount point while the Firebird container keeps running against a now-missing directory. This was the root cause of mapped-filesystem test failures observed in the Jaybird CI.Changes
README.md — added a
[!WARNING]callout under thevolumesparameter:Explains the checkout-order hazard
Recommends
${{ runner.temp }}(job-scoped, never touched by checkout) as the correct host pathIncludes a ready-to-use workflow snippet:
entrypoint.sh — non-fatal runtime warning when a volume host-path begins with
$GITHUB_WORKSPACE/(slash-bounded to avoid false-positives on sibling directories):