Skip to content

Enable CI/CD integration testing with Secret Manager#131

Closed
google-labs-jules[bot] wants to merge 1 commit into
stagingfrom
ci-secret-manager-integration
Closed

Enable CI/CD integration testing with Secret Manager#131
google-labs-jules[bot] wants to merge 1 commit into
stagingfrom
ci-secret-manager-integration

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor
  • Modified pkg/secrets: Now prioritizes environment variables over Secret Manager. This allows local overrides and simplifies testing, while still falling back to Secret Manager in CI if env vars are missing but GCLOUD_PROJECT_ID is present.
  • Updated deployment.yml: Authenticate with gcloud before the "Install, Build, Test" step. Passed GCLOUD_PROJECT_ID to the test environment.
  • Refactored Unit Tests: Updated api_client_test.go, passage_test.go, and ask_test.go. "Success" scenarios now rely on the environment (or Secret Manager) to provide the API URL, effectively converting them to integration tests when running in CI. "Error" scenarios continue to use mocks.
  • Added Database Test: Created pkg/app/database_integration_test.go to verify connectivity to USER_DATABASE_ID (Firestore) using a safe dummy user.

PR created automatically by Jules for task 535107038277093355 started by @julwrites

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@julwrites julwrites closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant