Skip to content

⚡ Bolt: [Performance] Eliminate 14 heap allocations per TUI draw frame for controls #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juntaochi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: [Performance] Eliminate 14 heap allocations per TUI draw frame for controls #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions src/ui/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,25 +962,28 @@ pub fn draw(f: &mut Frame, app: &mut App) {
f.render_widget(gauge, tuner_area);
}

let controls = if is_jp {
vec![
("▶再生", "SPC"),
("▶▶次", "]"),
("◀◀前", "["),
("音量＋", "+"),
("音量－", "-"),
("消音", "m"),
("電源", "q"),
// Bolt ⚡ Optimization:
// to avoid heavy allocations (e.g. format!) during the high frequency TUI render loop
// pre-calculate strings containing spaces and brackets here
let controls: &[(&str, &str)] = if is_jp {
&[
(" ▶再生", " [SPC] "),
(" ▶▶次", " []] "),
(" ◀◀前", " [[] "),
(" 音量＋", " [+] "),
(" 音量－", " [-] "),
(" 消音", " [m] "),
(" 電源", " [q] "),
]
} else {
vec![
("PLAY", "SPC"),
("SKIP", "]"),
("PREV", "["),
("VOL+", "+"),
("VOL-", "-"),
("MUTE", "m"),
("EXIT", "q"),
&[
(" PLAY", " [SPC] "),
(" SKIP", " []] "),
(" PREV", " [[] "),
(" VOL+", " [+] "),
(" VOL-", " [-] "),
(" MUTE", " [m] "),
(" EXIT", " [q] "),
]
};

Expand All @@ -994,12 +997,12 @@ pub fn draw(f: &mut Frame, app: &mut App) {
if i < btn_layout.len() {
let btn_text = Line::from(vec![
Span::styled(
format!(" {}", label),
*label,
Style::default()
.fg(theme.primary)
.add_modifier(Modifier::BOLD),
),
Span::styled(format!(" [{}] ", key), Style::default().fg(theme.dim)),
Span::styled(*key, Style::default().fg(theme.dim)),
]);

let mut btn_block = Block::default()
Expand Down
Loading