Add missing test features to README #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Nov 10, 2018
| # Samples of code which needs completion | ||
| completion_samples = [ | ||
| {'text': 'my_long', 'matches': ['my_long_variable_name', 'my_long_function_name']}, | ||
| {'text': 'a.', 'matches': ['a.foo', 'a.bar']} |
Member
There was a problem hiding this comment.
Is it worth copying the example from test_ipykernel.py here? I'm looking at these examples and wondering where the setup code is to create the variables you're completing.
Member
Author
There was a problem hiding this comment.
You're right, those examples are not relevant. We could use setup code to create some variables, or use built-in functions? I'll take a look at test_ipykernel.py
Member
Author
There was a problem hiding this comment.
Actually I didn't see you had examples on the repo. Maybe we could make it clearer that it's examples? And add a link to those examples in the README?
Member
There was a problem hiding this comment.
Yup, by all means. Maybe keep a shortened example in the README itself so it's readable at a glance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.