Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
# Ugh, I tried using matrix or something to explicitly generate only test pypi or prod pypi pipelines.
# But github actions is so shit, it's impossible to do any logic at all, e.g. doesn't support conditional matrix, if/else statements for variables etc.

needs: [build] # add all other jobs here
needs: [build, end2end_tests] # add all other jobs here

runs-on: ubuntu-latest

Expand Down
2 changes: 2 additions & 0 deletions extension/generate_manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ export function generateManifest({
version: pkg.version,
description: pkg.description,
permissions: permissions,
// Firefox for Android does not support extension keyboard shortcuts.
// https://bugzilla.mozilla.org/show_bug.cgi?id=1584246
commands: commands,
optional_permissions: optional_permissions,
manifest_version: v3 ? 3 : 2,
Expand Down
1 change: 0 additions & 1 deletion extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "1.0.2.2",
"version_name": "released on 2026.01.20",
"description": "Reliably capture links and webpage content in a plaintext file (org-mode/markdown)",
"main": "dist/background.js",
"scripts": {
"test": "jest",
"build": "rollup --config",
Expand Down
9 changes: 7 additions & 2 deletions extension/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,13 @@ const compile = inputs => { return {
// huh! so if I build all files in one go, it figures out the shared files properly it seems
// however it still inlines webextension stuff into one of the files? e.g. common
manualChunks: id => { // ugh, seems a bit shit?
if (id.includes('webextension-polyfill')) {
return 'webextension-polyfill' // move it in a separate chunk
const third_party = [
'webextension-polyfill',
]
for (const x of third_party) {
if (id.includes(x)) {
return `third_party/${x}` // move it in a separate chunk
}
}
},
},
Expand Down
Loading