Skip to content

Conversation

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Oct 24, 2025

What type of PR is this?

/kind cleanup

  • Added log collection functionality to check_component_restart function
  • Automatically collect logs from previous container instances using kubectl logs -p when Karmada components are detected to have restarted
  • Save collected logs to $ARTIFACTS_PATH directory with filename format: ${component_name}-${pod_name}-previous-logs.log

What this PR does / why we need it:

  • Facilitate troubleshooting of component restart causes (OOM, panic, etc.)
  • Provide more detailed debugging information to improve issue identification efficiency
  • Collect logs alongside other E2E test artifacts for comprehensive test reporting

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • Log collection only occurs when component restarts are detected, no impact on normal test flow
  • Added error handling to ensure log collection failures don't interrupt test execution

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 24, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @XiShanYongYe-Chang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the debugging capabilities of E2E tests by introducing automatic log collection for restarted Karmada components. When a component restart is detected, the system now captures logs from the previous container instance, saving them as artifacts. This change aims to streamline troubleshooting of issues like OOM errors or panics, providing more comprehensive data for efficient problem identification and resolution, while ensuring no disruption to the standard test flow.

Highlights

  • Enhanced E2E Test Debugging: Implemented automatic collection of previous container logs for restarted Karmada components during E2E tests.
  • Log Collection Mechanism: Utilizes "kubectl logs -p" to retrieve logs from prior container instances, saving them to the "$ARTIFACTS_PATH" for analysis.
  • Impact on Troubleshooting: Provides crucial debugging information for investigating component restarts (e.g., OOM, panic) without affecting normal test execution.
  • Robustness: Includes error handling to ensure that failures during log collection do not interrupt the ongoing test execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xishanyongye-chang. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the E2E test script to automatically collect logs from previous container instances when a component restart is detected. This is a valuable addition for debugging failures like OOMs or panics. The implementation is straightforward and includes error handling to prevent log collection failures from interrupting the test flow. I've provided one suggestion to improve the shell script's style and make the error reporting more helpful.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the collect-previous-container-log branch from 55ad4de to d15b156 Compare October 24, 2025 03:41
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.22%. Comparing base (a892fef) to head (d15b156).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6871      +/-   ##
==========================================
- Coverage   46.24%   46.22%   -0.02%     
==========================================
  Files         692      692              
  Lines       47194    47194              
==========================================
- Hits        21825    21817       -8     
- Misses      23717    23722       +5     
- Partials     1652     1655       +3     
Flag Coverage Δ
unittests 46.22% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RainbowMango
Copy link
Member

cc @zach593

@XiShanYongYe-Chang
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants