-
Notifications
You must be signed in to change notification settings - Fork 1k
Collect container logs for restarted components in E2E tests #6871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Collect container logs for restarted components in E2E tests #6871
Conversation
Summary of ChangesHello @XiShanYongYe-Chang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the debugging capabilities of E2E tests by introducing automatic log collection for restarted Karmada components. When a component restart is detected, the system now captures logs from the previous container instance, saving them as artifacts. This change aims to streamline troubleshooting of issues like OOM errors or panics, providing more comprehensive data for efficient problem identification and resolution, while ensuring no disruption to the standard test flow. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the E2E test script to automatically collect logs from previous container instances when a component restart is detected. This is a valuable addition for debugging failures like OOMs or panics. The implementation is straightforward and includes error handling to prevent log collection failures from interrupting the test flow. I've provided one suggestion to improve the shell script's style and make the error reporting more helpful.
Signed-off-by: changzhen <[email protected]>
55ad4de to
d15b156
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6871 +/- ##
==========================================
- Coverage 46.24% 46.22% -0.02%
==========================================
Files 692 692
Lines 47194 47194
==========================================
- Hits 21825 21817 -8
- Misses 23717 23722 +5
- Partials 1652 1655 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @zach593 |
|
/retest |
What type of PR is this?
/kind cleanup
$ARTIFACTS_PATHdirectory with filename format:${component_name}-${pod_name}-previous-logs.logWhat this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: