-
Notifications
You must be signed in to change notification settings - Fork 150
Update karmada-operator requirement for PDB resources #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update karmada-operator requirement for PDB resources #931
Conversation
Summary of ChangesHello @RainbowMango, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Karmada operator's security documentation to accurately reflect its requirement for managing PodDisruptionBudgets (PDBs). By adding PDB permissions to the operator's role, the documentation now clearly states that the operator can ensure application availability during voluntary disruptions, aligning with best practices for robust cluster management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for karmada-operator permissions to include the necessary rights for managing PodDisruptionBudget resources. The changes are applied to both the English and Chinese versions of the component permission documentation. The update is clear and aligns with the goal of supporting PDB for Karmada components. I have one minor suggestion to improve the wording in the Chinese documentation for better clarity.
i18n/zh/docusaurus-plugin-content-docs/current/administrator/security/component-permission.md
Show resolved
Hide resolved
Signed-off-by: RainbowMango <[email protected]>
63c86c2 to
e3a99e1
Compare
|
cc @windsonsea |
windsonsea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
This pull request updates the Karmada operator's security documentation to accurately reflect its requirement for managing PodDisruptionBudgets (PDBs). By adding PDB permissions to the operator's role.
Which issue(s) this PR fixes:
Part of karmada-io/karmada#6282
Special notes for your reviewer: