Move some text editor fields from Part to Common#693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-part text editor support (for scalability) is WIP. This is a small amount of progress towards that aim (a subset of easy steps).
The
highlighteris moved out ofCommonto allow the latter to be unparametrised.Commonis then made a field ofEditor, allowing usage of everything but thehighlighterfrom theEditorAPI (which is intended only for single-Partusage).EditGuard::activatenow callsfocus_lostregardless of the read-only status of the text (minor simplification).