Skip to content

fix: keep amount display above keypad on short screens - #567

Merged
kelly-musk merged 1 commit into
kellymusk:mainfrom
lemarjohnny781:fix/mobile-amount-keypad-overlap
Sep 4, 2026
Merged

fix: keep amount display above keypad on short screens#567
kelly-musk merged 1 commit into
kellymusk:mainfrom
lemarjohnny781:fix/mobile-amount-keypad-overlap

Conversation

@lemarjohnny781

Copy link
Copy Markdown
Contributor

Summary

Closes #


Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • 🚀 New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing behaviour to change)
  • ♻️ Refactor (no functional change, code quality improvement)
  • 🎨 UI / design update
  • 📦 Dependency update
  • 🔧 Configuration / tooling change
  • 📝 Documentation update
  • 🔒 Security fix

Changes Made


Testing

  • Manual testing in local development (npm run dev)
  • Unit tests added or updated (npm test)
  • Existing tests still pass (npm test)
  • Tested on Stellar Testnet (if blockchain changes are included)
  • Tested with demo mode OFF (NEXT_PUBLIC_DEMO_MODE=false)
  • Verified on mobile viewport (if UI changes are included)

Test steps for reviewers:


Screenshots / Screen Recording

Before After

Checklist

Code Quality

  • Code follows the project's style and conventions (ESLint passes: npm run lint)
  • TypeScript types are correct (no new any without justification): npm run type-check
  • No secrets, wallet keys, or PII committed to the repository
  • New NEXT_PUBLIC_* variables added to .env.example (if applicable)

Observability

  • New API routes use captureError / log from lib/observability
  • New Stellar SDK calls are wrapped in try/catch forwarding to captureError
  • No sensitive data (private keys, mnemonics, tokens) passed to log.* or captureError

Security

  • User inputs are validated with Zod (or equivalent) before processing
  • No new server-side secrets are exposed via NEXT_PUBLIC_* variables
  • Webhook signatures are verified where applicable
  • Rate limiting applied to new public API endpoints (Upstash)

Accessibility (UI changes only)

  • Interactive elements have accessible labels (aria-label, aria-describedby)
  • Colour contrast meets WCAG AA (4.5:1 for normal text)
  • Keyboard navigation works for new interactive components

Documentation

  • Inline code comments added for non-obvious logic
  • README or docs updated if the change affects setup or configuration
  • SECURITY.md updated if the change affects the security surface (rare)

Deployment Notes


Related Issues / PRs

closes #490

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@lemarjohnny781 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@kelly-musk
kelly-musk merged commit 41fb019 into kellymusk:main Sep 4, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(mobile): numeric keypad on charge page overlaps the amount display on small screens

2 participants