Skip to content

feat(recall): organize generated insights and quality - #1367

Merged
wesm merged 6 commits into
mainfrom
docs/recall-generated-insights-spec
Aug 9, 2026
Merged

feat(recall): organize generated insights and quality#1367
wesm merged 6 commits into
mainfrom
docs/recall-generated-insights-spec

Conversation

@wesm

@wesm wesm commented Aug 8, 2026

Copy link
Copy Markdown
Member
  • Recall now groups durable corpus entries and saved model-written reports under one URL-backed workspace, so users no longer have to infer how two kinds of reusable context relate.
  • Generated insights expose their complete session scope before execution, preserve that scope across tab changes, and retain deep links plus export, publish, retry, and delete workflows.
  • Deterministic recommendations and evidence move to Quality, making the model-written versus measured-data boundary explicit; the former /insights route is a clean break and falls through to Sessions.
  • Read-only backends keep access to saved generated reports while hiding the unsupported corpus, and the public docs now describe both surfaces and their privacy boundary.

wesm added 5 commits August 8, 2026 08:53
Recall now has a corpus management surface while generated reports remain mixed with deterministic quality analytics. Define the route, capability, component, scope, and documentation boundaries before implementation so the split preserves saved-report access and removes hidden filter coupling.
The initial design left request context, route fallback, capability derivation, and panel-state lifetime open to interpretation. Make those contracts explicit so implementation preserves local date bucketing, existing read-only behavior, and user scope across tab switches.
Route parsing cannot establish whether an insight exists before the archive loads. Base tab selection on parameter presence so routing is deterministic, then leave parsing and lookup to report selection.
Keep durable context and generated reports together under Recall, with explicit report scope that survives tab changes and deep links. Move deterministic session signals to Quality so model-written output is no longer mixed with measured facts.
The approved design has been implemented and verified, so keep the durable product documentation under Recall and Quality instead of retaining the temporary working spec.
@wesm

wesm commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

UI captures from the screenshot fixture:

  • Generated report content is synthetic.
  • Quality shows aggregate metrics from a bounded, scrubbed fixture; real saved insights, machine identity, paths, and blocked/private terms are removed.

Recall — Generated insights

Recall Generated insights

Quality

Quality

@roborev-ci

roborev-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown

roborev: Combined Review (d155848)

Changes need fixes before merge: three medium-severity issues will likely cause runtime or CI failures.

Medium

  • frontend/src/lib/components/recall/GeneratedInsightsPanel.svelte:71sessions.agents.sort(...) mutates a shared reactive array inside $derived.by, potentially triggering Svelte’s unsafe-mutation error and reordering other agent selectors. Sort a copy with [...sessions.agents].sort(...).

  • frontend/e2e/insights-quality.spec.ts:109 — Playwright tests still reference the removed /insights route, .insights-page, and “Insights” navigation item. Update affected tests in insights-quality.spec.ts, usage.spec.ts, session-list.spec.ts, and appearance-a11y.spec.ts to use /quality or /recall?tab=generated and the new selectors and link expectations.

  • scripts/docs_assets_test.go:391, scripts/docs_assets_test.go:497 — Documentation fixtures still generate the old /insights/, insights.png, and insight-content.png assets, so built-site and asset publishing/hydration tests will fail. Update builtDocsRoutes and writeGeneratedAssets for /quality/, /recall/, quality.png, and recall-generated-insights.png.


Reviewers: 2 done | Synthesis: codex, 22s | Total: 13m2s

Keep the Recall split isolated from shared session state and preserve the metadata users rely on when reviewing saved reports. Align browser coverage and docs fixtures with the new Recall and Quality destinations so the shipped routes and published assets stay in sync.
@roborev-ci

roborev-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown

roborev: Combined Review (efe438f)

The UI reorganization is sound, but legacy Insights links need migration support.

Medium

  • frontend/src/lib/stores/router.svelte.ts:55 — Removing the insights route causes existing /insights bookmarks and shared /insights?insight=<id> report links to silently fall back to Sessions. Add a legacy redirect: route URLs containing insight to /recall?tab=generated, and other /insights URLs to /quality, preserving applicable parameters.

Reviewers: 2 done | Synthesis: codex, 10s | Total: 8m46s

@wesm
wesm merged commit e58680d into main Aug 9, 2026
24 checks passed
@wesm
wesm deleted the docs/recall-generated-insights-spec branch August 9, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant