Skip to content

Move route map to app/routes.ts (Remix CLI convention) - #127

Merged
kody-bot merged 1 commit into
mainfrom
devin/1790825809-app-routes-ts
Oct 1, 2026
Merged

kody-bot merged 1 commit into
mainfrom
devin/1790825809-app-routes-ts

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Moves the route map from app/config/routes.ts to app/routes.ts, where the Remix CLI looks for it (remix doctor / remix routes). The aggregate becomes a named export, and the CLI requires that name to be routes. This is recommendation 3 from the rc.4 upgrade (#124), which Kent approved.

- export default { ...rootRoutes, oauthToken: ..., ... } as const
+ export const routes = { ...rootRoutes, oauthToken: ..., ... } as const
  • Importers (import routes from '#app/config/routes.ts') become import { routes } from '#app/routes.ts'. Type-only imports become import { type routes } ..., which is the repo's formatter style.
  • remix.json asset allowlist: app/config/routes.ts becomes app/routes.ts. The admin client imports the route map in the browser, so the new path has to be on the allowlist.
  • The named route groups (rootRoutes, oauthRoutes, mcpRoutes, adminRoutes, adminApiRoutes) are unchanged.
  • I deliberately did not add app/actions/controller.tsx. Handlers stay in app/routes/*, so remix doctor still warns Root route map is missing action controller app/actions/controller.tsx. That is expected. Before this PR it also warned Project is missing app/routes.ts, and that warning is now gone.

Test Plan

  • npm run format, npm run lint (no errors; the only two warnings are pre-existing ones in app/helpers/version.test.ts), and npm run validate (typecheck plus 271/271 tests) all pass.
  • npx remix doctor passes, with only the expected controller warning left.
  • npx remix routes loads and prints the full route tree.
  • rg "config/routes" finds no matches outside node_modules.
  • Dev server smoke test against test/fixtures/audio:
    • /admin returns 200
    • /assets/app/routes.ts returns 200
    • /assets/app/config/routes.ts returns 404
    • / returns 302 to /admin
    • /health returns 200

Checklist

  • Tests updated (import paths only)
  • Docs updated (no docs referenced the old path)

Screenshots

N/A: this is a file move with no UI change.

Link to Devin session: https://app.devin.ai/sessions/a572734e245b461eab5cb184593959c9
Open in Devin Desktop: https://app.devin.ai/desktop/session/a572734e245b461eab5cb184593959c9?variant=devin
Requested by: @kentcdodds


Devin Review

Co-Authored-By: Kent C. Dodds <me@kentcdodds.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 524c00ee-79c4-4057-b99b-4b4f9214de6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@kody-bot
kody-bot merged commit 39b56fb into main Oct 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants