-
Notifications
You must be signed in to change notification settings - Fork 128
Authors page UI #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Authors page UI #192
Conversation
Signed-off-by: Kaushik Tak <[email protected]>
… author-description instead of max-10 Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
…tCounts in utils for reusability Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaushiktak19 I have reviewed the previous code that you added in this pr, can you please also :
- resolve the merge conflict
- push all the new code changes as we discussed for the cards here
- update the hero section in this pr itself
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
|
@amaan-bhati , Changes updates -
Build Check :
Also, have fixed the 404-page image responsiveness, in this PR. |
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaushiktak19 Update the pr description, summarise everything with the latest changes and the current state of the page. Document the pr properly so that it is easier for the second reviewer to review.
Okay, i will update the PR description. |
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaushiktak19 I ran this page on local, and have following suggestions for the changes to be made:
-
the opacity of the images of the authors in the background should be reduced since it makes it very hard for the user to understand where to focus at the first glance, the background images with too much opacity is distracting.
-
responsiveness: in smaller screen sizes, the hero section is not looking good due to: 1. the heading and the description being too small, 2. the font weight being too less for it to pop out and grab user attention at first glance
-
in smaller screen sizes, the images of the authors in the background are too loud and has high opacity which makes it very difficukt to read what is written in the hero section, pay attention to the images attached:
- the filering/sorting functionality ui is not properly visible, the text inside it might be difficult to read at times, you can try a darker background for that or maybe a thicker glassmorphic effect for the same.
- take a look at the issues and the warnings listed in the terminal,
⚠ The "images.domains" configuration is deprecated. Please use "images.remotePatterns" configuration instead.is because of the recent deprication by nextjs, update thenext config fileproactively before it breaks in the future, please take a look at the other issues and warnings in the page too.
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaushiktak19 Please confirm if you have addressed the last comments on this pr, if yes, please give an update in a comment. Also, take a look at the merge conflicts. Once confirmed, we are good to go for the 2nd review and get this merged.⚡
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hey @kaushiktak19 Please take a look at the conflicts |






Related Tickets & Documents
No related issue - enhancement to improve author discoverability and page UX consistency.
Description
This update improves the Authors section by adding a search bar, A–Z/Z–A sorting. It also fixes the issue where some authors showed “No posts found” by filtering posts using ppmaAuthorName. The API now supports pagination and includes postId for content fetching.
In this PR revamp of the UI for authors page section is done. Introduced glassmorphism in author cards, search and filter; added a new bacground component and used that. In author cards, included more detailes - total numbe rof posts by author, linkedIn and decription (for ones available). Also, have fixed the 404-page image responsiveness, in this PR (as suggested).
Changes
Authors index:
Author details:
ppmaAuthorName(supports multi-author strings).API:
getAllPostsand includedpostId.fixed the 404-page image responsiveness
Type of Change
Testing
npm run buildsuccessfully with no errors.Build check :
Demo
Search & Sort, Load more button
(sorted based on alphabetical order) -
(search funtionality) -
Broken Links
Before :

After :

Environment and Dependencies
Checklist