-
Notifications
You must be signed in to change notification settings - Fork 128
Feat: Revamp of Navbar UI #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
…bugs to fix Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ui is good to start with, the design as well as the implementation also looks great. But there are only a few things we should be careful about:
- on scrolling, when the navbar shrinnks, we need to be careful about
- the navbar height being a little less so that the user can focus more on the page rather than focusing on the navbar
- the searchbar is not responsive, the placeholder and the font size can be reduced i order to make it responsive
- The ui of the navbar needs to be responsive, thus, you should try and take care of the nav respinsiveness for medium sized devices as well, since the nav elements are overflowing the navbar
- the thickness of the navbar in terms of the height shoukld be reduced otherwise it would take up a good amount of space in the mobile screen which is not good for user experience
- confirm if the saerch functionality is working properly, when typing, the search results do appear but on clicking a specific search result blog, it is not redirecting me to the blog, kindly check
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
|
Hey @kaushiktak19 is this ready for the 2nd review from your end? |
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
Signed-off-by: Kaushik Tak <[email protected]>
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.



Related Tickets & Documents
No related issue - enhancement to improve navbar and UX.
Description
Changes
Type of Change
Testing
npm run buildsuccessfully with no errors.Demo
Environment and Dependencies
Checklist