Repository navigation
CLI: Update SDK to 9ac854e2d73931cce7e4879b8505b1e11cf1e27c and add new commands/flags - #292
Open
kernel-internal[bot] wants to merge 6 commits into
Open
kernel-internal[bot] wants to merge 6 commits into
kernel-internal[bot] wants to merge 6 commits into
Conversation
…ew commands/flags - Bump kernel-go-sdk to 3c8b90c8bea096937d6cee06eabd6076e1801376 - browser-pools create: add --allowed-host (BrowserPoolNewParams.Network.AllowedHosts) - browser-pools update: add --allowed-host / --clear-allowed-hosts (BrowserPoolUpdateParams.Network.AllowedHosts); clear flags preserve the other network flags passed in the same command - browser-pools get: show Allowed Hosts - browsers update/create: refresh help now that leased pooled browsers support allowlist changes; --pool-* + --allowed-host now points users at the pool flags - Fix: browsers create --private-host/--proxy-route without --allowed-host no longer sends an invalid empty "allowed_hosts": [] list Tested against the live API: browser-pools create --allowed-host, browser-pools get (Allowed Hosts row), browser-pools update --allowed-host --private-host, update --clear-allowed-hosts --private-host (kept private hosts), empty --allowed-host rejected, browser-pools acquire + browsers update --allowed-host on a leased browser + release, browsers create --private-host (no allowed_hosts sent). Resources cleaned up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…r telemetry stream by type server-side - Bump kernel-go-sdk to 6d9c6187b9e9ddbe1a1546a48b1544dacbb62417 - `kernel browsers telemetry stream --types` now sends BrowserTelemetryStreamParams.Type so the API filters events server-side (client-side filtering is kept as a fallback) Tested: browsers telemetry stream <id> --replay all --types cdp_command,api_call (only matching events delivered; server sends id-only frames for skipped events, which the SDK decoder ignores); unfiltered stream for comparison; go test ./... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kernel-internal
Bot
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f44e578. Configure here.
Bumps kernel-go-sdk to v0.123.0 (64c58f83184c). The SDK change since the previous version is release metadata only; full enumeration of api.md methods vs CLI commands found no new coverage gaps (config-registry endpoints are x-cli-skip). Tested: go build ./... (no new commands/flags to smoke test) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kernel-internal
Bot
changed the title
An --allowed-host whose entries were all blank was dropped, so a browser or pool was created with unfiltered egress. Fail instead on create and update. Document that other pool network flags replace the whole network config and remove an existing allowlist, and stop sending an empty proxy_routes list on browser create.
…onfirm_transaction - Bump kernel-go-sdk to 9ac854e2d73931cce7e4879b8505b1e11cf1e27c - vaults items invoke <vault> <key> confirm_transaction --params/--spec-file for ConfirmTransactionVaultItemOperationRequestParam (status, transaction_type, amount, currency, occurred_at), validated client-side - Document merchant_category / merchant_category_code on KernelCardSpec and include them in vault item output Tested: go test ./...; against the live API, kernel cards create with merchant_category fields reached server validation (rejected because the Kernel wallet was not enrolled, which needs a cardholder passkey); confirm_transaction param validation and the advertised-operation check. Test vault cleaned up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kernel-internal
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Go SDK to 9ac854e2d73931cce7e4879b8505b1e11cf1e27c and adds CLI commands/flags for new SDK methods.
SDK Update
Coverage Analysis
This PR was generated by performing a full enumeration of SDK methods and CLI commands. Every SDK method in api.md is reachable from the CLI, except the
x-cli-skipConfig Registry endpoints.browsers curlandsearchreach their endpoints over raw HTTP rather than through the typed SDK methods, as before.SDK changes covered:
network.allowed_hosts).BrowserTelemetryStreamParams.Type).confirm_transactionvault item operation (ConfirmTransactionVaultItemOperationRequestParam) andmerchant_category/merchant_category_codeonKernelCardVaultItemSpecParam.These were intentionally not added:
Telemetry.ExportandTelemetry.StorageonBrowserPoolNew/Update/AcquireParams, andTelemetry.ExportonBrowserUpdateParams. The API rejects export and storage on pools and silently ignores export onPATCH /browsers.AuditLogExportChunkParams.Limitis still not exposed. It was already missing before this SDK change, andaudit-logs downloadmanages chunk paging itself.ProxyID,DisableDefaultProxy, the managed-authProxyandBrowserTelemetry) are still covered by the newer flags that replaced them.New Commands
kernel vaults items invoke <vault> <key> confirm_transaction --params|--spec-fileforclient.Vaults.Items.PerformOperation()withOfConfirmTransaction. It requiresstatus,transaction_type,amount,currencyandoccurred_at. The CLI checks the enums, that amount is a non-negative integer and that occurred_at is an ISO 8601 timestamp, and it rejects unknown keys. Before this change, invokingconfirm_transactionfell through to the parameterless path and sent an invalid body.New Flags
kernel browser-pools create --allowed-hostforBrowserPoolNewParams.Network.AllowedHostskernel browser-pools update --allowed-host/--clear-allowed-hostsforBrowserPoolUpdateParams.Network.AllowedHostskernel browsers telemetry stream --typesnow sendsBrowserTelemetryStreamParams.Typeto the API (server-side filter).kernel vaults cards create --provider kernel --specdocumentsmerchant_categoryandmerchant_category_codeforKernelCardVaultItemSpecParam.MerchantCategory/MerchantCategoryCode. The spec is raw JSON that is passed through as-is, and both fields now appear in vault item output.Other changes
kernel browser-pools getshows an Allowed Hosts row. The help text and README for allowlists on pooled browsers are updated.browsers create --private-hostwithout--allowed-hostno longer sends"allowed_hosts": [].--allowed-hostis rejected.Testing
go test ./...passes. New unit tests cover pool allowlists, stream types, theconfirm_transactionrequest body and its param validation.--typesfiltering.merchant_category/merchant_category_codereached server validation. The server stopped it with "wallet is pending_authorization", because enrolling a Kernel wallet needs a cardholder passkey, so the full card flow could not be run.confirm_transaction: checked the missing-params and invalid-status errors and the available_operations check against a live item.Triggered by: kernel/kernel-go-sdk@9ac854e
Reviewer: @kernel-internal[bot]
🤖 Generated with Claude Code