Repository navigation
Update bundled browser image runtime dependencies - #446
Merged
Merged
Conversation
sjmiller609
marked this pull request as ready for review
October 9, 2026 16:02
sjmiller609
commented
Oct 9, 2026
hiroTamada
approved these changes
Oct 10, 2026
hiroTamada
left a comment
Contributor
There was a problem hiding this comment.
what’s the production use case for Docker inside browser VMs? is something using it today, or is it bundled for future use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Published base verification
v3.0.8-v1.6.2was successfully built and published for amd64, arm64, and arm/v7: https://github.com/kernel/neko/actions/runs/37966960969.Note
Medium Risk
Changes privileged in-image Docker/containerd runtime versions used when
WITHDOCKERis enabled; mis-versioned or incompatible binaries could break nested container startup despite checksum pinning.Overview
Upgrades the Docker-in-Docker stage in both chromium headful and headless images from
docker:29.1.3-dindto29.8.2-dind, and during that stage runs a newshared/docker/update-containerd.shscript that downloads containerd 2.4.1 static binaries (daemon +containerd-shim-runc-v2) with pinned SHA-256 checks for amd64/arm64, installing them over Docker’s bundled containerd to pick up a newer embedded gRPC stack.The headful image also pins the Neko base from
3.0.8-v1.6.0to3.0.8-v1.6.1; the final images still copy the same Docker binaries from thedockerstage into/usr/local/bin.Reviewed by Cursor Bugbot for commit 14b7267. Bugbot is set up for automated code reviews on this repo. Configure here.