chore/increase offline tests coverage #33
Conversation
Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
86af228 to
a7800c5
Compare
|
I think Edit: Edit2: I think you need to break the second commit in more parts. It's very unclear what is dead code being removed and what is changing |
|
testdata/expected/results-offline.csv was already kind of big and you've 4x it, into 12k lines (1.3MB). Any way to break it into smaller files? If not in this MR, at least a plan on how we could achieve that |
tales-aparecida
left a comment
There was a problem hiding this comment.
Too many changes in a single commit
Replace repeated dbcursor None-checks with a shared helper. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Drop dead get_by_link/dupof/update_author/parse_link paths that no callers use anymore. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Use injectable _web_now so offline tests can freeze web page timestamps. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Extract prepare/publish helpers, injectable mail clock, and non-interactive compile path used by offline tests. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Extract prepare/publish/build_compilation and dumpall_web so offline tests can assert web output without writing pages alone. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Record mail and web exporter dumps in results-offline.csv and add a delete regression exercise. Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
I have considered that. |
a7800c5 to
b693997
Compare
Broke into separate commits for each change. |
Increase coverage test on offline testing.
testing_offline has gone from 61% to 69% total coverage.
We are now including:
The _repsources/*.py files should be more effectively covered by testing_trackers.py.
How to run
Execute tests
PYTHONPATH=. coverage run regzbot/commandl.py test --offlineCompile report
coverage report