Nfs uboot prompt#36
Merged
Merged
Conversation
The rpi4 u-boot prints 'U-Boot> ' but the default prompt was only '=> ', so we had to set it per board. bootloader_prompt is matched as a regex, so let the default match both '=> ' and 'U-Boot> '. Then boards with either prompt boot without an override. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
In device-dict mode tuxrun does not use LAVA's bcm2711-rpi-4-b device-type, so the kernel and ramdisk load addresses were missing and the parameters block did not render. Set them in NfsRpi4, same values as the LAVA device-type, and pass the device context_overrides to the device-dict render. Now the rpi4 boots in device-dict mode without a per-board device-dict. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The rpi4 device-dict and the NfsRpi4 class could use different ramdisk and dtb addresses. In device-dict mode the file values win, so the two boot paths could disagree. Set ramdisk 0x10000000 and dtb 0x08000000 in both, and add the kernel address and U-Boot prompt to the device-dict. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The device-dicts mounted /usr/bin/lsibcli into the docker shell, but the tool is not used. Remove the volume from all device-dicts. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get the rpi4 to boot over NFS in device-dict mode. Match both U-Boot prompts and set the kernel, ramdisk and dtb load addresses. Also drop the lsibcli mount we don't use.