metadata: write metadata.json early so it survives a hard kill#288
Merged
Conversation
tuxmake writes metadata.json once, in the finally block of run(). A graceful failure like a compile error or a SIGTERM still runs the finally, so we get the file. A hard kill does not. SIGKILL, the OOM killer or a CI kill -9 cannot be caught, so the finally never runs and we get no metadata.json. We lose data we already knew, like the compiler and tool versions. Now collect in two steps. After prepare() write the parts that do not depend on the build. At the end add the build results and write again. source stays late because kernelrelease may need a config. A finished build gets the same file as before. A killed build now keeps a partial file with the early data and no results key. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
metadata-early-write
branch
from
June 12, 2026 07:21
88b9905 to
8a98f61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tuxmake writes metadata.json once, in the finally block of run(). A graceful failure like a compile error or a SIGTERM still runs the finally, so we get the file.
A hard kill does not. SIGKILL, the OOM killer or a CI kill -9 cannot be caught, so the finally never runs and we get no metadata.json. We lose data we already knew, like the compiler and tool versions.
Now collect in two steps. After prepare() write the parts that do not depend on the build. At the end add the build results and write again. source stays late because kernelrelease may need a config.
A finished build gets the same file as before. A killed build now keeps a partial file with the early data and no results key.