cargo: Bump tss-esapi, picky-asn1-x509, and picky-asn1-der#1236
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Cargo.toml dependencies: ChangesDependency Bump: tss-esapi & ASN.1 crates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Line 59: Update the tss-esapi dependency declaration in Cargo.toml from
version "7.6.0" to "7.7.0" so the project picks up the Clang 22/bindgen opaque
type regression fix; keep the existing features (e.g., "generate-bindings")
unchanged in the tss-esapi entry to preserve current build behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ac5179bb-4485-473a-84ba-3e9de599d544
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
Bump: - tss-esapi to version 7.7.0 - picky-asn1-x509 to version 0.15.4 - picky-asn1-der to version 0.5.6 The tss-esapi version 7.7.0 allows building with clang 22. Also re-add the `generate-bindings` feature, which allows building in arches for which the bindings are not pre-generated. Note that this reverts changes made in keylime#1205. Resolves: keylime#1229 Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Bump:
tss-esapito version 7.7.0picky-asn1-x509to version 0.15.4picky-asn1-derto version 0.5.6The tss-esapi version 7.7.0 allows building with clang 22.
Also re-add the
generate-bindingsfeature, which allows building in arches for which the bindings are not pre-generated.Note that this reverts changes made in #1205.
Resolves: #1229
Summary by CodeRabbit